Reduce number of select for updates #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javitonino
approved these changes
Jun 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
+ Coverage 76.65% 77.32% +0.67%
==========================================
Files 103 106 +3
Lines 6724 6844 +120
==========================================
+ Hits 5154 5292 +138
+ Misses 1570 1552 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 488dca5 | Previous: 0d03d9f | Ratio |
|---|---|---|---|
tests/search/unit/search/test_fetch.py::test_highligh_error |
2289.783218994411 iter/sec (stddev: 0.000009044171956253212) |
2841.0684406726436 iter/sec (stddev: 0.000004954958228416619) |
1.24 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were using read/write transactions on places where it is not needed, thus causing a lot of contention on keys that are "get" often.
How was this PR tested?
Existing tests should cover