Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metrics for find/chat/ask #2216

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Jun 4, 2024

Description

This pr adds:

  • recording of first generative chunk yield metric
  • improve how we report slow queries

How was this PR tested?

Describe how you tested this PR.

@lferran lferran requested a review from a team June 4, 2024 11:59
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 607b5e5 Previous: 08db1e8 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 3019.6507854914644 iter/sec (stddev: 0.000006726336266689788) 3041.132211072051 iter/sec (stddev: 0.0000011628635974660105) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.16%. Comparing base (b551226) to head (9bffe44).
Report is 5 commits behind head on main.

Current head 9bffe44 differs from pull request most recent head 607b5e5

Please upload reports for the commit 607b5e5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2216      +/-   ##
==========================================
+ Coverage   77.15%   77.16%   +0.01%     
==========================================
  Files          94       94              
  Lines        6045     6044       -1     
==========================================
  Hits         4664     4664              
+ Misses       1381     1380       -1     
Flag Coverage Δ
ingest 71.48% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 2ef7862 into main Jun 4, 2024
77 checks passed
@lferran lferran deleted the metric-for-first-yielded-chunk branch June 4, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants