Skip to content

Commit

Permalink
include in schema (#2204)
Browse files Browse the repository at this point in the history
  • Loading branch information
lferran authored May 29, 2024
1 parent 205d127 commit 0ef3064
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions nucliadb/nucliadb/search/api/v1/ask.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@
description="Ask questions on a Knowledge Box",
tags=["Search"],
response_model=SyncAskResponse,
# Add this to OpenAPI schema when endpoint is not in beta anymore
include_in_schema=False,
)
@requires(NucliaDBRoles.READER)
@version(1)
Expand Down
2 changes: 0 additions & 2 deletions nucliadb/nucliadb/search/api/v1/resource/ask.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@
description="Ask questions to a resource",
tags=["Search"],
response_model=SyncAskResponse,
# Add this to OpenAPI schema when endpoint is not in beta anymore
include_in_schema=False,
)
@requires(NucliaDBRoles.READER)
@version(1)
Expand Down

3 comments on commit 0ef3064

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0ef3064 Previous: 08db1e8 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 2927.184003240466 iter/sec (stddev: 0.000002465812514274786) 3041.132211072051 iter/sec (stddev: 0.0000011628635974660105) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0ef3064 Previous: 08db1e8 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 3014.437057668455 iter/sec (stddev: 0.0000029885035442303955) 3041.132211072051 iter/sec (stddev: 0.0000011628635974660105) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0ef3064 Previous: 08db1e8 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 3014.3036090687024 iter/sec (stddev: 9.609487671596415e-7) 3041.132211072051 iter/sec (stddev: 0.0000011628635974660105) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.