Fix pgreport about missing student_answers openedx#435

nttks · Oct 20, 2015 · b415802 · b415802
1 parent 5fe7fa6
commit b415802
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lms/djangoapps/pgreport/tests/test_views.py b/lms/djangoapps/pgreport/tests/test_views.py
@@ -343,6 +343,20 @@ def test_get_correctmap_data(self):
 
     def test_get_student_answers_data(self):
         sum_answers = {}
+
+        # Invalid answers
+        # None, empty
+        student_answers = None
+        return_answers = self.pgreport._get_student_answers_data(
+            sum_answers, student_answers)
+        self.assertEquals(return_answers, {})
+
+        student_answers = {}
+        return_answers = self.pgreport._get_student_answers_data(
+            sum_answers, student_answers)
+        self.assertEquals(return_answers, {})
+
+        # Valid answers
         student_answers = {'1_2_1': 'abcd', '1_2_2': 'abcd', '1_2_3': 'xyz'}
         return_answers = self.pgreport._get_student_answers_data(
             sum_answers, student_answers)

diff --git a/lms/djangoapps/pgreport/views.py b/lms/djangoapps/pgreport/views.py
@@ -189,6 +189,9 @@ def _get_correctmap_data(self, sum_correct_map, correct_map):
 
     def _get_student_answers_data(self, sum_student_answers, student_answers):
 
+        if not student_answers:
+            return sum_student_answers
+
         for key, answers in student_answers.items():
             answers_data = {}
             if isinstance(answers, list):