Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

feat: save data access keys #87

Draft
wants to merge 7 commits into
base: feat-token-store-access-key
Choose a base branch
from
Draft

feat: save data access keys #87

wants to merge 7 commits into from

Conversation

PiDelport
Copy link
Collaborator

@PiDelport PiDelport commented Jun 1, 2021 •
edited
Loading

Note

This PR ended up depending on a lot of preceding work, especially around protected channel usage, so this description tracks that.

Depends on PRs:

@PiDelport PiDelport added the feat New feature or request label Jun 1, 2021
@PiDelport PiDelport self-assigned this Jun 1, 2021
@PiDelport PiDelport marked this pull request as draft June 1, 2021 15:43
@PiDelport PiDelport mentioned this pull request Jun 2, 2021
Merged
@PiDelport PiDelport force-pushed the he-exec-access-key branch 3 times, most recently from ed57679 to c871aa2 Compare June 3, 2021 07:23
@PiDelport PiDelport mentioned this pull request Jun 3, 2021
Merged
@PiDelport PiDelport changed the base branch from main to refactor-ecall-tests June 3, 2021 13:39
@PiDelport PiDelport force-pushed the he-exec-access-key branch 4 times, most recently from 8045b13 to d6d8c0d Compare June 7, 2021 17:30
@PiDelport PiDelport added the M: auth enclave Module: Authorisation enclave (rtc_auth_enclave) label Jun 8, 2021
@PiDelport PiDelport added this to the Execution token issuance milestone Jun 8, 2021
@PiDelport PiDelport force-pushed the he-exec-access-key branch 2 times, most recently from ba91f2f to 9f9d1cf Compare June 9, 2021 14:48
@PiDelport PiDelport changed the base branch from refactor-ecall-tests to feat-rkyv-binhelpers June 9, 2021 14:53
This was referenced Jun 9, 2021
Merged
Open
@PiDelport PiDelport force-pushed the he-exec-access-key branch from 9f9d1cf to f297a27 Compare June 9, 2021 19:04
@PiDelport PiDelport force-pushed the feat-rkyv-binhelpers branch from 1a8d9f7 to 7e2cad3 Compare June 10, 2021 08:10
@PiDelport PiDelport force-pushed the he-exec-access-key branch from f297a27 to fda592e Compare June 10, 2021 08:13
@PiDelport PiDelport force-pushed the feat-rkyv-binhelpers branch 4 times, most recently from 35edca6 to c7ea482 Compare June 10, 2021 16:54
@PiDelport PiDelport changed the base branch from feat-rkyv-binhelpers to main June 10, 2021 17:50
@PiDelport PiDelport force-pushed the he-exec-access-key branch from fda592e to 649db4e Compare June 10, 2021 17:51
@PiDelport PiDelport mentioned this pull request Jun 11, 2021
Merged
@PiDelport PiDelport force-pushed the feat-more-enclave-messages branch 2 times, most recently from 733e097 to 77479a8 Compare June 21, 2021 12:04
@PiDelport PiDelport force-pushed the he-exec-access-key branch 2 times, most recently from 9e62fab to 7ec1aba Compare June 21, 2021 13:09
@PiDelport PiDelport removed this from the Execution token issuance milestone Jun 22, 2021
@PiDelport PiDelport force-pushed the he-exec-access-key branch from 7ec1aba to bbb2889 Compare June 22, 2021 16:31
@PiDelport PiDelport changed the base branch from feat-more-enclave-messages to he-issue-exec-token June 22, 2021 16:31
@PiDelport
Copy link
Collaborator Author

(Rebased to resolve with #99)

@PiDelport PiDelport force-pushed the he-exec-access-key branch 2 times, most recently from a353681 to 0b498d6 Compare June 25, 2021 20:05
@longtomjr longtomjr changed the base branch from he-issue-exec-token to main July 1, 2021 07:31
@PiDelport PiDelport mentioned this pull request Jul 6, 2021
Draft
@PiDelport PiDelport force-pushed the he-exec-access-key branch from 0b498d6 to a1ccd29 Compare July 7, 2021 19:27
@PiDelport PiDelport changed the base branch from main to feat-token-store-access-key July 7, 2021 19:29
@PiDelport PiDelport mentioned this pull request Jul 7, 2021
Open
@PiDelport
Copy link
Collaborator Author

@longtomjr, @Nghondzweni: Okay, once #110 is in, this should finally be ready for merging!

What's here should be ready for final review.

@PiDelport PiDelport force-pushed the he-exec-access-key branch from a1ccd29 to 6cb2364 Compare July 7, 2021 19:55
@PiDelport PiDelport mentioned this pull request Jul 7, 2021
Draft
@PiDelport PiDelport removed their assignment Jul 7, 2021
@PiDelport PiDelport force-pushed the feat-token-store-access-key branch from 378f713 to 6ef2cf5 Compare July 8, 2021 01:29
@PiDelport PiDelport force-pushed the he-exec-access-key branch from 6cb2364 to ee5cce1 Compare July 8, 2021 01:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@longtomjr longtomjr Awaiting requested review from longtomjr

@Nghondzweni Nghondzweni Awaiting requested review from Nghondzweni

Assignees
No one assigned
Labels
feat New feature or request M: auth enclave Module: Authorisation enclave (rtc_auth_enclave)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an ECALL to save access-key hash and UUID for a data set
1 participant
@PiDelport