Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

address cargo check ✨ and enable cargo fix 🎉 #77

Merged
merged 21 commits into from
Jun 2, 2021
Merged

address cargo check ✨ and enable cargo fix 🎉 #77

merged 21 commits into from
Jun 2, 2021

Conversation

PiDelport
Copy link
Collaborator

These changes are not high priority, but I've been accumulating them on the side, until cargo check passes cleanly in this branch.

The main functional change is to mark all the use imports that have side effects for enclave linking: this means that we can now use cargo fix without breaking the build!

@PiDelport PiDelport self-assigned this May 20, 2021
@PiDelport PiDelport force-pushed the refactor-lint-cleanup branch from f89b681 to c0b8b9e Compare May 27, 2021 11:38
@PiDelport
Copy link
Collaborator Author

(Rebased for #78: f89b681...c0b8b9e)

@PiDelport
Copy link
Collaborator Author

PiDelport commented May 27, 2021 •
edited
Loading

I added a few more changes to follow updates and make cargo doc build cleanly too.

@PiDelport PiDelport force-pushed the refactor-lint-cleanup branch from c7318ad to ead4d8b Compare May 31, 2021 15:36
@PiDelport
Copy link
Collaborator Author

(Rebased for #60: c7318ad...ead4d8b)

@PiDelport PiDelport force-pushed the refactor-lint-cleanup branch from 0557abe to bb167d7 Compare June 1, 2021 10:35
@PiDelport
Copy link
Collaborator Author

(Rebased to refresh)

PiDelport added 19 commits June 1, 2021 16:51
@PiDelport
style(rtc_data_service): prefix unused variables
8172e8c
@PiDelport
refactor(rtc_data_service): remove unused variable
01fce2b 
load_certs will open the path.
@PiDelport
refactor(rtc_data_service): drop unused imports
5b105a0
@PiDelport
chore(rtc_uenclave): disable warn(unused_imports)
bd5f233 
These imports are for the generated bindings.rs.
@PiDelport
refactor(rtc_data_service) drop unused mut
d5adc89
@PiDelport
docs(rtc_uenclave): RtcDataEnclave::get_exec_token
17a9d2e
@PiDelport
check(rtc_data_service): unused imports
ffc6d24
@PiDelport
check(rtc_auth_enclave): mark import for ECALL linking
f31072c
@PiDelport
check(rtc_data_enclave): mark import for ECALL linking
6abb36b
@PiDelport
check(rtc_data_enclave): unused imports
ca25fbf
@PiDelport
check(rtc_data_enclave,data_upload): unused imports
ef90e99
@PiDelport
style(rtc_data_enclave): unnecessary parentheses around pattern
ad48880
@PiDelport
check(rtc_data_enclave,data_upload): unnecessary mut
3796ed5
@PiDelport
check(rtc_data_enclave): unused feature(const_generics) and feature(c…
e11cc2b 
…onst_evaluatable_checked)

These usages were moved to rtc_tenclave.
@PiDelport
check(rtc_auth_enclave,rtc_data_enclave,rtc_tenclave): drop feature(u…
f3d88cf 
…nsafe_block_in_unsafe_fn)

> warning: the feature `unsafe_block_in_unsafe_fn` has been stable since
1.51.0 and no longer requires an attribute to enable
@PiDelport
doc(rtc_uenclave): use automatic link instead
087c7b5 
https://doc.rust-lang.org/rustdoc/lints.html#non_autolinks
@PiDelport
doc(rtc_data_service): follow rename: RtcEnclave → RtcDataEnclave
7396ccd
@PiDelport
doc(rtc_tenclave): simplify reference: std::fs::File → File
9bd8657 
(sgx_std ends up with a prefix of `std::untrusted::fs` instead of
`std::fs`)
@PiDelport
check(rtc_tenclave,dh): peer identity code not used yet, but will be
5de6b49
@PiDelport PiDelport force-pushed the refactor-lint-cleanup branch from bb167d7 to fcad1f2 Compare June 1, 2021 14:52
@PiDelport
Copy link
Collaborator Author

Thanks! 🎉

@PiDelport PiDelport merged commit 0fdd5a7 into main Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@longtomjr longtomjr longtomjr approved these changes

@Nghondzweni Nghondzweni Awaiting requested review from Nghondzweni

Assignees

@PiDelport PiDelport

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PiDelport @longtomjr