Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include button, label, and style components #42

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Nov 7, 2017

I wanted to go ahead and take a stab at implementing part of pydata/xarray#1627 with vdom, then realized we didn't have the label element or the style element. This introduces those as well as <button/> even though we don't have data bindings / callbacks.

@rgbkrk rgbkrk requested a review from menglewis November 7, 2017 18:06
Copy link
Contributor

@menglewis menglewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgbkrk
Copy link
Member Author

rgbkrk commented Nov 8, 2017

I just now realized that the @nteract/core team did not have admin privileges on vdom. I just set that, so now you're able to merge PRs on nteract/vdom @menglewis. 😄

@rgbkrk rgbkrk merged commit 78fa2b5 into nteract:master Nov 8, 2017
@rgbkrk rgbkrk deleted the include-more-missing-components branch November 8, 2017 16:06
@rgbkrk rgbkrk mentioned this pull request Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants