Refactor naming and expand client docstrings

[willingc]

• Adds/edits docstrings for clients
• update filenames to avoid confusion
  - reorder classes in notebook client file for maintainability
• add autodoc doc pages

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 4830650

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 4830650 in #71. cc @willingc.

[todo]

verify that *args is not needed

bookstore/bookstore/client/nb_client.py

Lines 112 to 117 in 4830650

	# TODO: verify that *args is not needed
	self.kernel_id = kernel_id
	self.name = name
	self.last_activity = last_activity
	self.execution_state = execution_state
	self.connections = connections

---

This comment was generated by todo based on a TODO comment in 4830650 in #71. cc @willingc.

[todo]

double check *args, **kwargs are not necessary

bookstore/bookstore/client/nb_client.py

Lines 139 to 144 in 4830650

	# TODO: double check *args, **kwargs are not necessary
	self.path = path
	self.name = name
	self.type = session_type
	self.kernel = KernelInfo(**kernel)
	self.notebook = notebook

---

This comment was generated by todo based on a TODO comment in 4830650 in #71. cc @willingc.

[todo]

refactor from lambda to a def

bookstore/bookstore/client/nb_client.py

Lines 150 to 155 in 4830650

	# TODO: refactor from lambda to a def
	nb_client_gen = lambda: (NotebookClient(x) for x in list_running_servers())
	sessions = {x.url: x.sessions for x in nb_client_gen()}
	@classmethod
	def current_server(cls):

---

This comment was generated by todo based on a TODO comment in 4830650 in #71. cc @willingc.

[todo]

Add a check for success

bookstore/bookstore/client/store_client.py

Lines 23 to 24 in 4830650

	# TODO: Add a check for success
	resp = requests.put(target_url, **req)

---

This comment was generated by todo based on a TODO comment in 4830650 in #71. cc @willingc.

[willingc]

@mpacer let's keep iterating on the clients

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 755969c

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 755969c in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 697987e

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 697987e in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in b96f684

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in b96f684 in #71. cc @willingc.

[mpacer]

So much greatness here! Thank you @willingc.

There were a couple of things that I would have wanted changed around the object APIs, but this is such a dramatic improvement that I'd be willing to merge this even though I think those changes need to be made in a later PR.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in ca51029

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in ca51029 in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 3fb5b93

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 3fb5b93 in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 763dd0b

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 763dd0b in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 77e1476

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 77e1476 in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 06e2ba5

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 06e2ba5 in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 56d8216

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 56d8216 in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in e9b3330

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in e9b3330 in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 29ddf01

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 29ddf01 in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 5a0d843

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 5a0d843 in #71. cc @willingc.

[willingc]

@mpacer @MSeal I've gone back and simplified this PR to docstring changes, a missed import, autodoc of files, and black autoformat. Let's go ahead and merge. Then we can begin tackling the other PR. We should decide whether to do a phone call review or break it up into smaller PRs. Thanks.

[MSeal]

LGTM, I'll let @mpacer merge as I'm only getting up to speed on bookstore code / opinions.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in 8addca3

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in 8addca3 in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in a4c1392

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in a4c1392 in #71. cc @willingc.

[todo]

(Clarify) We want to test our bookstore endpoints, but it's no fun having

bookstore/bookstore/client/nb_client.py

Lines 4 to 9 in a0a78e6

	TODO: (Clarify) We want to test our bookstore endpoints, but it's no fun having
	to do this in an insecure fashion. Better would be to have some security in
	place.
	Example
	-------

---

This comment was generated by todo based on a TODO comment in a0a78e6 in #71. cc @willingc.