-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GH-153] - using operation API for ConflictingArgumentAssignment anal…
…yzer
- Loading branch information
Showing
8 changed files
with
70 additions
and
164 deletions.
There are no files selected for viewing
38 changes: 1 addition & 37 deletions
38
...Substitute.Analyzers.CSharp/DiagnosticAnalyzers/ConflictingArgumentAssignmentsAnalyzer.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,55 +1,19 @@ | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.CSharp; | ||
| using Microsoft.CodeAnalysis.CSharp.Syntax; | ||
| using Microsoft.CodeAnalysis.Diagnostics; | ||
| using NSubstitute.Analyzers.CSharp.Extensions; | ||
| using NSubstitute.Analyzers.Shared; | ||
| using NSubstitute.Analyzers.Shared.DiagnosticAnalyzers; | ||
|
|
||
| namespace NSubstitute.Analyzers.CSharp.DiagnosticAnalyzers | ||
| { | ||
| [DiagnosticAnalyzer(LanguageNames.CSharp)] | ||
| internal sealed class ConflictingArgumentAssignmentsAnalyzer : AbstractConflictingArgumentAssignmentsAnalyzer<SyntaxKind, InvocationExpressionSyntax, ExpressionSyntax, ElementAccessExpressionSyntax> | ||
| internal sealed class ConflictingArgumentAssignmentsAnalyzer : AbstractConflictingArgumentAssignmentsAnalyzer<SyntaxKind, InvocationExpressionSyntax, ElementAccessExpressionSyntax> | ||
| { | ||
| public ConflictingArgumentAssignmentsAnalyzer() | ||
| : base(NSubstitute.Analyzers.CSharp.DiagnosticDescriptorsProvider.Instance, CallInfoCallFinder.Instance) | ||
| { | ||
| } | ||
|
|
||
| protected override SyntaxKind InvocationExpressionKind { get; } = SyntaxKind.InvocationExpression; | ||
|
|
||
| protected override IEnumerable<ExpressionSyntax> GetArgumentExpressions(InvocationExpressionSyntax invocationExpressionSyntax) | ||
| { | ||
| return invocationExpressionSyntax.ArgumentList.Arguments.Select(arg => arg.Expression); | ||
| } | ||
|
|
||
| protected override SyntaxNode GetSubstituteCall(SyntaxNodeAnalysisContext syntaxNodeContext, IMethodSymbol methodSymbol, InvocationExpressionSyntax invocationExpressionSyntax) | ||
| { | ||
| return invocationExpressionSyntax.GetParentInvocationExpression(); | ||
| } | ||
|
|
||
| protected override int? GetIndexerPosition(SyntaxNodeAnalysisContext syntaxNodeAnalysisContext, ElementAccessExpressionSyntax indexerExpressionSyntax) | ||
| { | ||
| var position = syntaxNodeAnalysisContext.SemanticModel.GetConstantValue(indexerExpressionSyntax.ArgumentList.Arguments.First().Expression); | ||
| return (int?)(position.HasValue ? position.Value : null); | ||
| } | ||
|
|
||
| protected override ISymbol GetIndexerSymbol(SyntaxNodeAnalysisContext syntaxNodeAnalysisContext, ElementAccessExpressionSyntax indexerExpressionSyntax) | ||
| { | ||
| return syntaxNodeAnalysisContext.SemanticModel.GetSymbolInfo(indexerExpressionSyntax).Symbol ?? | ||
| syntaxNodeAnalysisContext.SemanticModel.GetSymbolInfo(indexerExpressionSyntax.Expression).Symbol; | ||
| } | ||
|
|
||
| protected override SyntaxNode GetAssignmentExpression(ElementAccessExpressionSyntax indexerExpressionSyntax) | ||
| { | ||
| if (indexerExpressionSyntax.Parent is AssignmentExpressionSyntax assignmentExpressionSyntax) | ||
| { | ||
| return assignmentExpressionSyntax.Right; | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
| } | ||
| } |
12 changes: 0 additions & 12 deletions
12
src/NSubstitute.Analyzers.CSharp/Extensions/SyntaxExtensions.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 1 addition & 36 deletions
37
...itute.Analyzers.VisualBasic/DiagnosticAnalyzers/ConflictingArgumentAssignmentsAnalyzer.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,19 @@ | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.Diagnostics; | ||
| using Microsoft.CodeAnalysis.VisualBasic; | ||
| using Microsoft.CodeAnalysis.VisualBasic.Syntax; | ||
| using NSubstitute.Analyzers.Shared.DiagnosticAnalyzers; | ||
| using NSubstitute.Analyzers.VisualBasic.Extensions; | ||
|
|
||
| namespace NSubstitute.Analyzers.VisualBasic.DiagnosticAnalyzers | ||
| { | ||
| [DiagnosticAnalyzer(LanguageNames.VisualBasic)] | ||
| internal sealed class ConflictingArgumentAssignmentsAnalyzer : AbstractConflictingArgumentAssignmentsAnalyzer<SyntaxKind, InvocationExpressionSyntax, ExpressionSyntax, InvocationExpressionSyntax> | ||
| internal sealed class ConflictingArgumentAssignmentsAnalyzer : AbstractConflictingArgumentAssignmentsAnalyzer<SyntaxKind, InvocationExpressionSyntax, InvocationExpressionSyntax> | ||
| { | ||
| public ConflictingArgumentAssignmentsAnalyzer() | ||
| : base(NSubstitute.Analyzers.VisualBasic.DiagnosticDescriptorsProvider.Instance, CallInfoCallFinder.Instance) | ||
| { | ||
| } | ||
|
|
||
| protected override SyntaxKind InvocationExpressionKind { get; } = SyntaxKind.InvocationExpression; | ||
|
|
||
| protected override IEnumerable<ExpressionSyntax> GetArgumentExpressions(InvocationExpressionSyntax invocationExpressionSyntax) | ||
| { | ||
| return invocationExpressionSyntax.ArgumentList.Arguments.Select(arg => arg.GetExpression()); | ||
| } | ||
|
|
||
| protected override SyntaxNode GetSubstituteCall(SyntaxNodeAnalysisContext syntaxNodeContext, IMethodSymbol methodSymbol, InvocationExpressionSyntax invocationExpressionSyntax) | ||
| { | ||
| return invocationExpressionSyntax.GetParentInvocationExpression(); | ||
| } | ||
|
|
||
| protected override int? GetIndexerPosition(SyntaxNodeAnalysisContext syntaxNodeAnalysisContext, InvocationExpressionSyntax indexerExpressionSyntax) | ||
| { | ||
| var position = syntaxNodeAnalysisContext.SemanticModel.GetConstantValue(indexerExpressionSyntax.ArgumentList.Arguments.First().GetExpression()); | ||
| return (int?)(position.HasValue ? position.Value : null); | ||
| } | ||
|
|
||
| protected override ISymbol GetIndexerSymbol(SyntaxNodeAnalysisContext syntaxNodeAnalysisContext, InvocationExpressionSyntax indexerExpressionSyntax) | ||
| { | ||
| return syntaxNodeAnalysisContext.SemanticModel.GetSymbolInfo(indexerExpressionSyntax).Symbol ?? | ||
| syntaxNodeAnalysisContext.SemanticModel.GetSymbolInfo(indexerExpressionSyntax.Expression).Symbol; | ||
| } | ||
|
|
||
| protected override SyntaxNode GetAssignmentExpression(InvocationExpressionSyntax indexerExpressionSyntax) | ||
| { | ||
| if (indexerExpressionSyntax.Parent is AssignmentStatementSyntax assignmentExpressionSyntax) | ||
| { | ||
| return assignmentExpressionSyntax.Right; | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.