Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nest application does not update the angular.json file #94

Closed
dungahk opened this issue Mar 15, 2019 · 2 comments · Fixed by #98
Closed

Nest application does not update the angular.json file #94

dungahk opened this issue Mar 15, 2019 · 2 comments · Fixed by #98
Labels
type: question

Comments

@dungahk
Copy link
Contributor

dungahk commented Mar 15, 2019 •
edited
Loading

I have generated a nest application using app.nest but the angular.json file does not update.

Very good stuff you guys have! Thanks for the project, really enjoying it.
@NathanWalker
Copy link
Member

Thanks @dungahk! since we aren’t using any angular build architect setups with nest we don’t modify for it however that may change in future. It should not affect your usage though I don’t believe?

@dungahk
Copy link
Contributor Author

dungahk commented Mar 15, 2019

Hi @NathanWalker thanks for the response.

Because Nx adds a project to angular.json I was expecting xplat to do the same, I guess it doesn't hurt to have this as an option in the future like you mentioned, right?

I'm happy to try a PR.

Thanks again for the stuff you've done!

@dungahk dungahk mentioned this issue Mar 17, 2019
Merged
NathanWalker pushed a commit that referenced this issue Mar 17, 2019
@dungahk @NathanWalker
feat(generators): add angularJson option to app.nest (#98)
adec8fb 
Add the project to angular.json along with a couple of targets.
It still misses the test target
close #94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(generators): add angularJson option to app.nest
2 participants
@NathanWalker @dungahk