Skip to content

Commit

Permalink
arch: Use VIRTUAL_REGISTER_P predicate.
Browse files Browse the repository at this point in the history
gcc/ChangeLog:

	* config/arm/arm.cc (thumb1_legitimate_address_p):
	Use VIRTUAL_REGISTER_P predicate.
	(arm_eliminable_register): Ditto.
	* config/avr/avr.md (push<mode>_1): Ditto.
	* config/bfin/predicates.md (register_no_elim_operand): Ditto.
	* config/h8300/predicates.md (register_no_sp_elim_operand): Ditto.
	* config/i386/predicates.md (register_no_elim_operand): Ditto.
	* config/iq2000/predicates.md (call_insn_operand): Ditto.
	* config/microblaze/microblaze.h (CALL_INSN_OP): Ditto.
  • Loading branch information
ubizjak committed Apr 20, 2023
1 parent 272484d commit cae48a9
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 20 deletions.
7 changes: 2 additions & 5 deletions gcc/config/arm/arm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9105,9 +9105,7 @@ thumb1_legitimate_address_p (machine_mode mode, rtx x, int strict_p)
else if (REG_P (XEXP (x, 0))
&& (REGNO (XEXP (x, 0)) == FRAME_POINTER_REGNUM
|| REGNO (XEXP (x, 0)) == ARG_POINTER_REGNUM
|| (REGNO (XEXP (x, 0)) >= FIRST_VIRTUAL_REGISTER
&& REGNO (XEXP (x, 0))
<= LAST_VIRTUAL_POINTER_REGISTER))
|| VIRTUAL_REGISTER_P (XEXP (x, 0)))
&& GET_MODE_SIZE (mode) >= 4
&& CONST_INT_P (XEXP (x, 1))
&& (INTVAL (XEXP (x, 1)) & 3) == 0)
Expand Down Expand Up @@ -13905,8 +13903,7 @@ arm_eliminable_register (rtx x)
{
return REG_P (x) && (REGNO (x) == FRAME_POINTER_REGNUM
|| REGNO (x) == ARG_POINTER_REGNUM
|| (REGNO (x) >= FIRST_VIRTUAL_REGISTER
&& REGNO (x) <= LAST_VIRTUAL_REGISTER));
|| VIRTUAL_REGISTER_P (x));
}

/* Return GENERAL_REGS if a scratch register required to reload x to/from
Expand Down
3 changes: 1 addition & 2 deletions gcc/config/avr/avr.md
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,7 @@
operands[0] = copy_to_mode_reg (<MODE>mode, operands[0]);
}
else if (REG_P (operands[0])
&& IN_RANGE (REGNO (operands[0]), FIRST_VIRTUAL_REGISTER,
LAST_VIRTUAL_REGISTER))
&& VIRTUAL_REGISTER_P (operands[0]))
{
// Byte-wise pushing of virtual regs might result in something like
//
Expand Down
5 changes: 2 additions & 3 deletions gcc/config/bfin/predicates.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
(define_predicate "symbol_ref_operand"
(match_code "symbol_ref"))

;; True for any non-virtual or eliminable register. Used in places where
;; True for any non-virtual and non-eliminable register. Used in places where
;; instantiation of such a register may cause the pattern to not be recognized.
(define_predicate "register_no_elim_operand"
(match_operand 0 "register_operand")
Expand All @@ -184,8 +184,7 @@
op = SUBREG_REG (op);
return !(op == arg_pointer_rtx
|| op == frame_pointer_rtx
|| (REGNO (op) >= FIRST_PSEUDO_REGISTER
&& REGNO (op) <= LAST_VIRTUAL_REGISTER));
|| VIRTUAL_REGISTER_P (op));
})

;; Test for an operator valid in a BImode conditional branch
Expand Down
3 changes: 1 addition & 2 deletions gcc/config/h8300/predicates.md
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,7 @@
return !(op == stack_pointer_rtx
|| op == arg_pointer_rtx
|| op == frame_pointer_rtx
|| IN_RANGE (REGNO (op),
FIRST_PSEUDO_REGISTER, LAST_VIRTUAL_REGISTER));
|| VIRTUAL_REGISTER_P (op));
})

;; Return nonzero if X is a constant whose absolute value is greater
Expand Down
5 changes: 2 additions & 3 deletions gcc/config/i386/predicates.md
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@
return register_no_elim_operand (op, mode);
})

;; True for any non-virtual or eliminable register. Used in places where
;; True for any non-virtual and non-eliminable register. Used in places where
;; instantiation of such a register may cause the pattern to not be recognized.
(define_predicate "register_no_elim_operand"
(match_operand 0 "register_operand")
Expand All @@ -717,8 +717,7 @@

return !(op == arg_pointer_rtx
|| op == frame_pointer_rtx
|| IN_RANGE (REGNO (op),
FIRST_PSEUDO_REGISTER, LAST_VIRTUAL_REGISTER));
|| VIRTUAL_REGISTER_P (op));
})

;; Similarly, but include the stack pointer. This is used to prevent esp
Expand Down
3 changes: 1 addition & 2 deletions gcc/config/iq2000/predicates.md
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,7 @@
{
return (CONSTANT_ADDRESS_P (op)
|| (GET_CODE (op) == REG && op != arg_pointer_rtx
&& ! (REGNO (op) >= FIRST_PSEUDO_REGISTER
&& REGNO (op) <= LAST_VIRTUAL_REGISTER)));
&& ! VIRTUAL_REGISTER_P (op)));
})

;; Return nonzero if OP is valid as a source operand for a move
Expand Down
5 changes: 2 additions & 3 deletions gcc/config/microblaze/microblaze.h
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,8 @@ extern enum reg_class microblaze_regno_to_class[];
since they may change into reg + const, which the patterns
can't handle yet. */
#define CALL_INSN_OP(X) (CONSTANT_ADDRESS_P (X) \
|| (GET_CODE (X) == REG && X != arg_pointer_rtx\
&& ! (REGNO (X) >= FIRST_PSEUDO_REGISTER \
&& REGNO (X) <= LAST_VIRTUAL_REGISTER)))
|| (GET_CODE (X) == REG && X != arg_pointer_rtx \
&& ! VIRTUAL_REGISTER_P (X)))

/* True if VALUE is a signed 16-bit number. */
#define SMALL_OPERAND(VALUE) \
Expand Down

0 comments on commit cae48a9

Please sign in to comment.