Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.21 #95

Merged
merged 11 commits into from
Aug 18, 2024
2 changes: 1 addition & 1 deletion .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-22.04, windows-2022, macos-12, macos-14]
go: [ '1.20', '1.21', '1.22' ]
go: [ '1.21', '1.22' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this commit should be squashed with the previous one. It's a little confusing when reviewing it in the order of commit history.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, technically it creates an invalid (always failing) test job after go.mod is upgraded, but this line isn't.

exclude:
# Only latest Go version for Windows and MacOS.
- os: windows-2022
Expand Down