Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#780] If clause to run on python3.8 on ubuntu-22.04 with GH actions. #32

Closed
wants to merge 1 commit into from

Conversation

MaxGelbakhiani
Copy link

@MaxGelbakhiani MaxGelbakhiani commented Aug 14, 2023

Fix to run s3-tests on Ubuntu with GH actions

Signed-off-by: Maksim Gelbakhiani <max@nspcc.ru>
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop [#780] prefix from the commit message, it shouldn't be a prefix, and it's a number from some different repository. "Refs. nspcc-dev/neofs-s3-gw#780" maybe a bit more appropriate.

@@ -29,7 +29,7 @@ case "$ID" in
done

if [ -n "$missing" ]; then
echo "$0: Missing required packages: ${missing}." 1>&2
echo "$0: Missing required packages: ${missing}." 1>&2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change.

@vvarg229
Copy link
Collaborator

Why not just run tests using python 3.8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants