-
Notifications
You must be signed in to change notification settings - Fork 13
env: add attributes for storage nodes; config: include data files for published package #85
Conversation
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta" | |||
|
|||
[project] | |||
name = "neofs-testlib" | |||
version = "1.1.15" | |||
version = "1.1.17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surely need double grade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there was a problem and I needed to manually update the version in pypi, so now the latest is actually 1.1.16.
neofs_env.deploy_storage_nodes( | ||
count=4, | ||
attrs={ | ||
0: ["UN-LOCODE:RU MOW", "Price:22"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
different prices are doubtful to be the default setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values are from the current static dev-env. And since current tests rely on this dev-env, it is considered as the default. Actually, this code can be moved to testcases dir, maybe I will do it in the future. Cause this lib should provide only the basic blocks.
@@ -109,11 +109,14 @@ def deploy_inner_ring_node(self): | |||
self.inner_ring_nodes.append(new_inner_ring_node) | |||
|
|||
@allure.step("Deploy storage node") | |||
def deploy_storage_nodes(self, count=1): | |||
def deploy_storage_nodes(self, count=1, attrs: Optional[dict] = None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be not very connvenient to use with raw dictionary imo, and with separated count. Some settings like LOCODE are quite interpretable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example is needed, not sure if I understand you correctly
oh, im late |
No description provided.