Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

env: add attributes for storage nodes; config: include data files for published package #85

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

evgeniiz321
Copy link
Contributor

No description provided.

Evgeniy Zayats added 3 commits January 23, 2024 18:58
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
@roman-khimov roman-khimov merged commit 9c857d0 into nspcc-dev:master Jan 24, 2024
3 checks passed
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "neofs-testlib"
version = "1.1.15"
version = "1.1.17"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely need double grade?

Copy link
Contributor Author

@evgeniiz321 evgeniiz321 Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there was a problem and I needed to manually update the version in pypi, so now the latest is actually 1.1.16.

neofs_env.deploy_storage_nodes(
count=4,
attrs={
0: ["UN-LOCODE:RU MOW", "Price:22"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different prices are doubtful to be the default setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values are from the current static dev-env. And since current tests rely on this dev-env, it is considered as the default. Actually, this code can be moved to testcases dir, maybe I will do it in the future. Cause this lib should provide only the basic blocks.

@@ -109,11 +109,14 @@ def deploy_inner_ring_node(self):
self.inner_ring_nodes.append(new_inner_ring_node)

@allure.step("Deploy storage node")
def deploy_storage_nodes(self, count=1):
def deploy_storage_nodes(self, count=1, attrs: Optional[dict] = None):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may be not very connvenient to use with raw dictionary imo, and with separated count. Some settings like LOCODE are quite interpretable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example is needed, not sure if I understand you correctly

@cthulhu-rider
Copy link

oh, im late

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants