tests: fix rest gw tests #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d818092 to
9f23c0d
Compare
roman-khimov
requested changes
Apr 11, 2024
| {"fileName": "simple_obj_filename"}, | ||
| {"file-Name": "simple obj filename"}, | ||
| {"cat%jpeg": "cat%jpeg"}, | ||
| {"Filename": "simple_obj_filename"}, |
There was a problem hiding this comment.
I added a separate case for FileName
| @@ -335,11 +335,10 @@ def test_put_http_get_http(self, complex_object_size, simple_object_size, gw_par | |||
| @pytest.mark.parametrize( | |||
| "attributes", | |||
| [ | |||
| {"fileName": "simple_obj_filename"}, | |||
| {"file-Name": "simple obj filename"}, | |||
| {"cat%jpeg": "cat%jpeg"}, | |||
There was a problem hiding this comment.
You're removing it without a notice, it should be a separate commit. nspcc-dev/neofs-rest-gw#195 is the real reason (that we can't fix now).
There was a problem hiding this comment.
I thought it was an officially unsupported symbol in current rest gw, returned it back and skipped properly.
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
9f23c0d to
391592a
Compare
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
391592a to
60c0945
Compare
roman-khimov
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.