Add replication test with deny eACL #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprasolova
suggested changes
Oct 7, 2021
| Set eACL ${WIF_USER} ${CID} ${EACL_DENY_ALL_USER} | ||
|
|
||
| # The current ACL cache lifetime is 30 sec | ||
| Sleep ${NEOFS_CONTRACT_CACHE_TIMEOUT} |
There was a problem hiding this comment.
I suppose we can omit this sleep, because contracts cache is disabled in job and in virtualenv.
|
|
||
| ${DROP_SIMPLE} = Run Process neofs-cli control drop-objects -r ${NODE} --wif ${WIF_STORAGE} -o ${CID}/${OID} shell=True | ||
| Should Be Equal As Integers ${DROP_SIMPLE.rc} 0 | ||
| Log Many stdout: ${DROP_SIMPLE.stdout} stderr: ${DROP_SIMPLE.stderr} |
There was a problem hiding this comment.
Stderr wouldn't be logged if previous assert fails, it has no sense.
| # Tick epoch and sleep epoch time for replication | ||
| Tick Epoch | ||
| # We assume that during this time objects should be replicated | ||
| Sleep ${NEOFS_EPOCH_TIMEOUT} |
There was a problem hiding this comment.
Here test will sleep for 5 minutes. Maybe we should run Validate storage policy for object, until it succeds instead?
I've made some experiments, and I'm sure that on empty dev-env the object will be replicated much faster than one epoch time.
aprasolova
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add replication test with deny eACL due to nspcc-dev/neofs-node#881