You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a test set for compatibility with S3 API. This set has nothing to do with the specifics of the fact that S3 in NeoFS is served through a gate, not directly from the cluster. So if we are testing only S3 API, there is no point in writing about the gate. But if we test the gate as a standalone application (process) with its custom specifics (for example, reaction to a particular OS signal), then it is worth creating a set of s3/gate tests in the s3 test suite.
it's a bit strange to me to see test_s3_gate.py file in s3_gate besides seeing S3 API tests in it. Is this file intended for NeoFS S3 Gateway specifics not covered by the protocol?
i've left some questions and suggestions from my own, if u'll find any of them useful, feel free to postpone them via issues, i understand that this PR is about migration, not enhancements
i don't plan to look closely at the other tests (at least for now), hope @evgeniiz321@roman-khimov will help
I'd suggest creating a subgroup of s3_extensions and put neofs-s3-gw-specific tests there. Otherwise it's a standard S3 for bucket/multipart/locking/whatever.
S3 policy and cors tests were also moved to a more logical location
from the relevance to s3 gate point of view.
closes#707
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
There is a test set for compatibility with
S3 API
. This set has nothing to do with the specifics of the fact thatS3
inNeoFS
is served through a gate, not directly from the cluster. So if we are testing onlyS3 API
, there is no point in writing about the gate. But if we test thegate
as a standalone application (process) with its custom specifics (for example, reaction to a particular OS signal), then it is worth creating a set ofs3/gate
tests in thes3
test suite.Originally posted by @cthulhu-rider in #699 (review)
The text was updated successfully, but these errors were encountered: