Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: set OID in object returned from Head() #679

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

roman-khimov
Copy link
Member

3c47093 regression. Even though it's not a part of the protocol, clients expect it to be set.

3c47093 regression. Even though it's not
a part of the protocol, clients expect it to be set.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (3ac6276) to head (5f21541).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #679   +/-   ##
=======================================
  Coverage   60.23%   60.23%           
=======================================
  Files         165      165           
  Lines       22683    22684    +1     
=======================================
+ Hits        13663    13664    +1     
  Misses       8674     8674           
  Partials      346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not a funny fix but it was this way before so...

@carpawell carpawell merged commit 051c623 into master Jan 30, 2025
10 checks passed
@carpawell carpawell deleted the head-oid branch January 30, 2025 15:13
@roman-khimov
Copy link
Member Author

neofs-cli actually prints it. And tests rely on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants