Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: do not rely on internal proto.Message for public interfaces #678

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

roman-khimov
Copy link
Member

  1. This is wrong by definition.
  2. We only need a very small subset of it here in fact.

1. This is wrong by definition.
2. We only need a very small subset of it here in fact.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.21%. Comparing base (74d6159) to head (de6cc51).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
- Coverage   60.23%   60.21%   -0.02%     
==========================================
  Files         165      165              
  Lines       22683    22683              
==========================================
- Hits        13663    13659       -4     
- Misses       8674     8678       +4     
  Partials      346      346              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 3ac6276 into master Jan 30, 2025
9 of 10 checks passed
@roman-khimov roman-khimov deleted the crypto-protomessage branch January 30, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants