pool: Increase timeout to start NeoFS AIO Docker container for testing #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After recent changes, NeoFS AIO Docker container deploys NeoFS chain (deploy contracts, initial transfers, etc.) from scratch internally. This takes around 60 blocks (`~1m`), so AIO takes more than 1 minute to run. Previous test timeout `45s` was insufficient in practice, causing the test to fail. Timeout is increased to `2m`. The value is still pretty short, at the same time, failure to succeed within this duration will require an individual review for problems. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
carpawell
approved these changes
Jan 29, 2024
roman-khimov
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent changes, NeoFS AIO Docker container deploys NeoFS chain (deploy contracts, initial transfers, etc.) from scratch internally. This takes around 60 blocks (
~1m), so AIO takes more than 1 minute to run. Previous test timeout45swas insufficient in practice, causing the test to fail.Timeout is increased to
2m. The value is still pretty short, at the same time, failure to succeed within this duration will require an individual review for problems.