[#65] Allow no sign requests #79
Conversation
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
|
I do not know if it is necessary to restrict the access rights of owner (neofs-key) when no sign request is provided |
A good question, actually. But I think in current scheme it's unavoidable, every NeoFS request is signed and signer automatically has all the rights he has, otherwise why signing it. So it comes down to deployment/key management, an open gateway should just use some unique keys (maybe even ephemeral ones like HTTP gateway). |
| list, err := n.containerList(ctx) | ||
| if err != nil { | ||
| containerID := new(cid.ID) | ||
| if err := containerID.Parse(name); err != nil { |
There was a problem hiding this comment.
Not sure why do you do this change?
There was a problem hiding this comment.
containerList(ctx) returns containers whose owner is request sender. If we interact with some public container but sender is not its owner returned list will be empty
There was a problem hiding this comment.
It only works if we're using container ID as name, but we might as well use the name from attribute, so we need some logic to do that too. Your current code is at the same time an optimization for CID, so we can leave it, but instead of returning an error on the next line it should still try to fetch the container via listing (as was done by the old code). This way CIDs will work for public unauthenticated containers, but authenticated users could still access containers via names from attributes.
There was a problem hiding this comment.
What should we do if a public container is requested by name?
There was a problem hiding this comment.
Return error, you can't list all containers to find the one with proper name.
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Looking container up using the owner list if its name is not cid Signed-off-by: Denis Kirillov <denis@nspcc.ru>
closes #65
Signed-off-by: Denis Kirillov denis@nspcc.ru