[#53] *: Remove external pkg/errors dependency #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3874255 to
e3ee0d7
Compare
e3ee0d7 to
c469f64
Compare
Replaced functions from pkg/errors by functions from errors, fixed not fully correct comment Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
roman-khimov
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced functions from pkg/errors by functions from errors, fixed not fully correct comment
Note that in the old version of New (eg api/auth/center.go:68) we returned a message and a stack trace, now we return only a message. I couldn't find how to return also a stack trace using only errors package.