Build fixes #45
Merged
Build fixes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-Docker builds by default, no vendoring, more useful targets.
upx is nice, but not necessary for this and duplicating Makefile is just not good. Note that in absence of vendoring building this can be problematic at the moment because of private repository dependency, it'll be solved in future.
cmd/gate/app-settings.go:108:36 gosimple S1019: should use make(map[string]float64) instead
The same one as used by HTTP gate.
realloc
reviewed
May 14, 2021
| @@ -7,6 +7,7 @@ import ( | |||
| "github.com/gorilla/mux" | |||
| ) | |||
|
|
|||
| // Healthy is a health check interface. | |||
There was a problem hiding this comment.
We need to talk about healthchecks offline. IR and Storage node healthcheck interface in control g RPC API is about to be implemented. Maybe we should sync them somehow to make similar UX for operations.
realloc
reviewed
May 14, 2021
| @@ -1,12 +1,16 @@ | |||
| package misc | |||
|
|
|||
| const ( | |||
| // ApplicationName is gateway name. | |||
| ApplicationName = "neofs-s3-gate" | |||
There was a problem hiding this comment.
We have neofs-http-gate here for HTTP gate, so I've decided to follow this naming scheme. But yes, we're a bit inconsistent with neofs-X-gate repositories, neofs-X-gate application names and neofs-X-gw binaries.
realloc
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.