Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring API handlers #30

Merged
merged 13 commits into from
Aug 23, 2020
Merged

Refactoring API handlers #30

merged 13 commits into from
Aug 23, 2020

Conversation

im-kulikov
Copy link
Contributor

  • Implement ListObjectsV2 (closes Implement ListObjectsV2 #29)
  • Implement HeadBucket (closes Implement HeadBucket #28)
  • Implement DeleteMultipleObjects (closes Implement DeleteMultipleObjects method #26)
  • Add owner field for ListObjects method
  • Change returned error for GetBucketInfo method
  • Refactoring DeleteObject/DeleteObjects methods
  • Refactoring DeleteObject/DeleteObjects methods
  • Change NotFound error for objectFindID
  • Add Owner field into layer.ObjectInfo
  • Refactoring getAPIErrorResponse method
  • Add custom http headers constants
  • Refactoring WriteErrorResponse method
  • Change MimeTypes constants visibility

Evgeniy Kulikov added 13 commits August 22, 2020 05:32
Change MimeTypes constants visibility
b29c35a 
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Refactoring WriteErrorResponse method
b18b6f7 
- should receive error instead custom type
- change visibility of WriteResponse method

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Add custom http headers constants
08c60e4 
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Refactoring getAPIErrorResponse method
6cd81fc 
should receive base error type instead of custom errors

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Add Owner field into layer.ObjectInfo
b3e4d98 
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Change NotFound error for objectFindID
e73c9d8 
method should return gRPC status error

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Refactoring DeleteObject/DeleteObjects methods
898737c 
- methods should return api.DeleteErrors
- DeleteObjects should return only slice of errors
- don't add nil errors

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Refactoring DeleteObject/DeleteObjects methods
6104b17 
- methods should return api.DeleteErrors
- DeleteObjects should return only slice of errors
- don't add nil errors

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Change returned error for GetBucketInfo method
2fba128 
method should returns gRPC status errors

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Add owner field for ListObjects method
52561da 
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
[#26] Implement DeleteMultipleObjects
88c562c 
closes #26

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
[#28] Implement HeadBucket
30af72c 
closes #28

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
[#29] Implement ListObjectsV2
bc422a1 
ListObjectsV1 and ListObjectsV2 now simplified and return different results

closes #29

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
@im-kulikov im-kulikov added the enhancement Improving existing functionality label Aug 22, 2020
@im-kulikov im-kulikov added this to the Pre-public Release milestone Aug 22, 2020
@im-kulikov im-kulikov requested a review from pkorotkov August 22, 2020 02:54
@im-kulikov im-kulikov self-assigned this Aug 22, 2020
@im-kulikov im-kulikov merged commit 488290b into master Aug 23, 2020
@im-kulikov im-kulikov deleted the api-handlers branch August 23, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkorotkov pkorotkov pkorotkov approved these changes

Assignees
No one assigned
Labels
enhancement Improving existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ListObjectsV2 Implement HeadBucket Implement DeleteMultipleObjects method
2 participants
@im-kulikov @pkorotkov