authmate: Add lifetime for tokens #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should mention the issue |
838323e to
205650c
Compare
| return 0, err | ||
| } else if networkInfo, err := conn.NetworkInfo(ctx); err != nil { | ||
| return 0, err | ||
| } else { |
There was a problem hiding this comment.
Last return can be outside else branch
There was a problem hiding this comment.
It can't given the way variables are defined.
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
205650c to
6689af5
Compare
| @@ -283,7 +312,7 @@ func buildBearerTokens(key *keys.PrivateKey, table *eacl.Table, gatesKeys []*key | |||
| return bearerTokens, nil | |||
| } | |||
|
|
|||
| func buildSessionToken(key *keys.PrivateKey, oid *owner.ID, ctx *session.ContainerContext, gateKey *keys.PublicKey) (*session.Token, error) { | |||
| func buildSessionToken(key *keys.PrivateKey, oid *owner.ID, lifetime lifetimeOptions, ctx *session.ContainerContext, gateKey *keys.PublicKey) (*session.Token, error) { | |||
There was a problem hiding this comment.
It seems there are too many arguments. Maybe we should introduce some new type?
roman-khimov
approved these changes
Jun 28, 2021
KirillovDenis
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108