Streamline getobject #1085
Merged
Streamline getobject #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
| BucketInfo: bktInfo, | ||
| Encryption: encryptionParams, | ||
| if params != nil || encryptionParams.Enabled() { | ||
| // unfortunately this reader is useless for us in this case, we have to re-read another one. |
There was a problem hiding this comment.
It can be reused for sure (just piping into the decryption layer), but that's not our current primary target.
7720148 to
ff3699b
Compare
It works good for basic case when we don't need to handle encryption and range. Closes #1084. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
ff3699b to
49be936
Compare
roman-khimov
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.