Integrate search v2 #1082
Integrate search v2 #1082
Conversation
|
Replaces #1078? |
| @@ -65,6 +65,18 @@ type ( | |||
| Headers map[string]string | |||
| } | |||
|
|
|||
| // ObjectListResponseContent holds response data for object listing. | |||
| ObjectListResponseContent struct { | |||
There was a problem hiding this comment.
What are the uses for ObjectInfo? Can this be embedded into ObjectInfo? Do we need both or just one is sufficient?
There was a problem hiding this comment.
ObjectInfo in general appears with GetExtendedObjectInfo method to get full info about object. Moreover, it contains all object attributes, which are used for responses and other data manipulations
ObjectListResponseContent is a shorter version, which is enough to show a bucket listing
These fields have never been read since they was added in 47b560e. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
No longer need additional type also. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Neither TODO nor understanding why it might be needed. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
8cd5c2c to
5c54734
Compare
5c54734 to
ab35807
Compare
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Continuation token is not a OID any more. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Closes #1081. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
ab35807 to
d0a165b
Compare
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
d0a165b to
17d951f
Compare
| } | ||
|
|
||
| opts.SetCount(uint32(maxKeys)) | ||
|
|
||
| filters.AddFilter(object.AttributeFilePath, prefix, object.MatchCommonPrefix) |
There was a problem hiding this comment.
Not sure how prefix here...
| searchResults = append(searchResults, psr) | ||
| } | ||
|
|
||
| sortFunc := func(a, b prefixSearchResult) int { |
There was a problem hiding this comment.
...works with this sorting function. It's perfectly fine for objects with the same FilePath, but otherwise they're just different objects as per S3. Consider prefix "a" and "ab", "ac" objects.
There was a problem hiding this comment.
This method is used only for bucket listing. The prefix helps to filter similar objects or just list a "dir". There may be many objects with the same FilePath.
This sorting allows us to find the actual version of the object. But, maybe for this exact place, such multi-level sorting is too much. The question requires separate checks
There was a problem hiding this comment.
I'd expect this sorting to be prefix first and time second. Right now IIUC in a/ab/ac situation you can get any order even though technically everyone expects exactly "a, ab, ac". Then if there are multiple versions of "a", those should be sorted according to time stamps.
| prmSearch.Filters.AddFilter(object.AttributeFilePath, objectName, object.MatchStringEqual) | ||
| filters.AddFilter(object.AttributeFilePath, objectName, object.MatchStringEqual) | ||
| } else { | ||
| filters.AddFilter(object.AttributeFilePath, "", object.MatchCommonPrefix) |
There was a problem hiding this comment.
Can this ever really happen?
There was a problem hiding this comment.
At least one place exists in code, where we call with an empty object name - on the bucket removing. Any other place with user input may be involved as well
There was a problem hiding this comment.
Bucket removal retrieves all objects from bucket?
There was a problem hiding this comment.
You can't remove a bucket with objects. In out case with regular objects
There was a problem hiding this comment.
OK, but to check we need just a single result, not the whole list, is it taken into account anywhere?
Closes #1081