Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 500 instead of 404 for general error #252

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Return 500 instead of 404 for general error #252

merged 1 commit into from
Oct 25, 2024

Conversation

smallhive
Copy link
Contributor

Closes #250.

@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 23.38%. Comparing base (53dde94) to head (3d204e8).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
handlers/newObjects.go 0.00% 4 Missing ⚠️
handlers/objects.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   23.38%   23.38%           
=======================================
  Files          20       20           
  Lines        4781     4781           
=======================================
  Hits         1118     1118           
  Misses       3504     3504           
  Partials      159      159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smallhive smallhive force-pushed the 250-must-not-return-404-in-case-of-error branch from 90b8fc4 to 6bc56b6 Compare October 23, 2024 05:01
roman-khimov
roman-khimov reviewed Oct 23, 2024
View reviewed changes
@smallhive smallhive force-pushed the 250-must-not-return-404-in-case-of-error branch from 6bc56b6 to da459c4 Compare October 23, 2024 10:05
@smallhive
handler: Return http code according to the NeoFS error
3d204e8 
Closes #250.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 250-must-not-return-404-in-case-of-error branch from da459c4 to 3d204e8 Compare October 25, 2024 05:00
@roman-khimov roman-khimov merged commit 84bdfa8 into master Oct 25, 2024
12 of 14 checks passed
@roman-khimov roman-khimov deleted the 250-must-not-return-404-in-case-of-error branch October 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@tatiana-nspcc tatiana-nspcc Awaiting requested review from tatiana-nspcc tatiana-nspcc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

must not return 404 in case of error
2 participants
@smallhive @roman-khimov