Add support for Range header in object GET requests
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added function `formAllowRecord` to create `apiserver.Record`. Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
51776b3 to
cbda61a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 22.12% 22.79% +0.66%
==========================================
Files 17 18 +1
Lines 3507 3672 +165
==========================================
+ Hits 776 837 +61
- Misses 2579 2677 +98
- Partials 152 158 +6 ☔ View full report in Codecov by Sentry. |
smallhive
reviewed
Aug 23, 2024
cbda61a to
8813a62
Compare
smallhive
approved these changes
Aug 23, 2024
roman-khimov
requested changes
Aug 23, 2024
8813a62 to
fae80c6
Compare
The `Range` header is now accepted for `/objects/{cid}/by_id/{oid}` and
`/objects/{cid}/by_attribute/{oid}` requests.
Close #224.
Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
fae80c6 to
1d92ede
Compare
Add the `Accept-Ranges` header into the API responses for
`/objects/{cid}/by_id/{oid}` and `/objects/{cid}/by_attribute/{oid}`.
`bytes` is the only accepted range unit.
Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
Sorry, added. |
roman-khimov
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Rangeheader is now accepted for/objects/{cid}/by_id/{oid}and/objects/{cid}/by_attribute/{oid}requests.Close #224.