-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove double unescape path variable #240
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 22.12% 22.27% +0.15%
==========================================
Files 17 17
Lines 3507 3483 -24
==========================================
Hits 776 776
+ Misses 2579 2563 -16
+ Partials 152 144 -8 ☔ View full report in Codecov by Sentry. |
Have you checked that the test |
Closes #195. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
8116746
to
1835552
Compare
It is a good question. I tried this branch with the test. The test is green! |
That's good. Maybe you can activate this test in the testcases repository and also resolve the issues of the failing automated test here? |
Eventually, we decided with @roman-khimov not to move forward with these changes. The possible fix breaks another cases and it can't be done properly with current tool set |
Closes #195.