Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double unescape path variable #240

Closed
wants to merge 1 commit into from
Closed

Conversation

smallhive
Copy link
Contributor

Closes #195.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 22.27%. Comparing base (2da2ee6) to head (1835552).
Report is 1 commits behind head on master.

Files Patch % Lines
handlers/apiserver/rest-server.gen.go 66.66% 8 Missing ⚠️
handlers/newObjects.go 0.00% 2 Missing ⚠️
handlers/objects.go 0.00% 2 Missing ⚠️
handlers/preflight.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   22.12%   22.27%   +0.15%     
==========================================
  Files          17       17              
  Lines        3507     3483      -24     
==========================================
  Hits          776      776              
+ Misses       2579     2563      -16     
+ Partials      152      144       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smallhive smallhive marked this pull request as ready for review August 23, 2024 09:02
@tatiana-nspcc
Copy link
Contributor

tatiana-nspcc commented Aug 23, 2024

Have you checked that the test Test Put over REST, Get over REST with headers from neofs-testcases works with attributes {'cat%jpeg': 'cat%jpeg'}? It was marked as skipped earlier.

Closes #195.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive
Copy link
Contributor Author

Have you checked that the test Test Put over REST, Get over REST with headers from neofs-testcases works with attributes {'cat%jpeg': 'cat%jpeg'}? It was marked as skipped earlier.

It is a good question. I tried this branch with the test. The test is green!

@tatiana-nspcc
Copy link
Contributor

That's good. Maybe you can activate this test in the testcases repository and also resolve the issues of the failing automated test here?

@smallhive
Copy link
Contributor Author

smallhive commented Aug 27, 2024

Eventually, we decided with @roman-khimov not to move forward with these changes. The possible fix breaks another cases and it can't be done properly with current tool set

@smallhive smallhive closed this Aug 27, 2024
@smallhive smallhive deleted the double-unescape branch August 27, 2024 11:24
@smallhive smallhive mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad request returned for percent-encoded get_by_attribute
2 participants