Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/object: Allow zero payload ranges #3171

Merged
merged 4 commits into from
Feb 24, 2025
Merged

services/object: Allow zero payload ranges #3171

merged 4 commits into from
Feb 24, 2025

Conversation

cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Feb 24, 2025 •
edited
Loading

No description provided.

@cthulhu-rider cthulhu-rider mentioned this pull request Feb 24, 2025
Open
@cthulhu-rider cthulhu-rider marked this pull request as ready for review February 24, 2025 13:57
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.30769% with 31 lines in your changes missing coverage. Please review.

Project coverage is 23.12%. Comparing base (9ea14d4) to head (380d767).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/object/get/assembly_v2.go 0.00% 12 Missing ⚠️
pkg/services/object/get/util.go 0.00% 5 Missing ⚠️
cmd/neofs-cli/modules/object/range.go 0.00% 4 Missing ⚠️
pkg/services/object/server.go 0.00% 4 Missing ⚠️
pkg/local_object_storage/shard/range.go 62.50% 2 Missing and 1 partial ⚠️
pkg/services/object/get/assemble.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3171      +/-   ##
==========================================
+ Coverage   23.09%   23.12%   +0.02%     
==========================================
  Files         760      760              
  Lines       60349    60378      +29     
==========================================
+ Hits        13940    13960      +20     
- Misses      45415    45422       +7     
- Partials      994      996       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthulhu-rider
services/object: Drop unused code
4f99bff 
Not needed since f8f6b4c.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
services/object: Deduplicate getter call
bad5871 
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
services/object: Treat zero range as full payload in RANGE and HASH ops
ab91fdb 
Follow nspcc-dev/neofs-api#313.

Refs #3071.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
cli/object: Allow zero ranges in range and hash commands
380d767 
Follow nspcc-dev/neofs-api#313.

Closes #3071.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@roman-khimov roman-khimov merged commit 9f00c0c into master Feb 24, 2025
18 of 22 checks passed
@roman-khimov roman-khimov deleted the object/zero-range branch February 24, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@carpawell carpawell carpawell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cthulhu-rider @roman-khimov @carpawell