Fix/Fill split info for the first child correctly #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK RC8 does not attach a split ID to the first child in a split chain. Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
594fb04 to
9b23ffe
Compare
Codecov Report
@@ Coverage Diff @@
## master #2378 +/- ##
=======================================
Coverage 30.04% 30.05%
=======================================
Files 398 398
Lines 29806 29806
=======================================
+ Hits 8955 8957 +2
+ Misses 20126 20124 -2
Partials 725 725 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
Jun 12, 2023
cthulhu-rider
approved these changes
Jun 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK RC8 does not attach a split ID to the first child in a split chain.
See nspcc-dev/neofs-sdk-go#448 and https://nspcc-dev.github.io/neofs-node/191/#suites/beb587d64f4c3e0a7b76bb9b5b406a00/57ccae6fb58af59b.