Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Morph and metrics panics #2358

Merged

Conversation

notimetoname
Copy link
Contributor

Some teach-me-how-rebase stuff.

Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
@notimetoname notimetoname added bug Something isn't working hot labels May 24, 2023
@notimetoname notimetoname self-assigned this May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #2358 (820d4d1) into master (0e29c77) will increase coverage by 0.01%.
The diff coverage is 71.42%.

❗ Current head 820d4d1 differs from pull request most recent head b2f0e20. Consider uploading reports for the commit b2f0e20 to get more accurate results

@@            Coverage Diff             @@
##           master    #2358      +/-   ##
==========================================
+ Coverage   29.93%   29.94%   +0.01%     
==========================================
  Files         398      398              
  Lines       29743    29746       +3     
==========================================
+ Hits         8903     8907       +4     
+ Misses      20122    20121       -1     
  Partials      718      718              
Impacted Files Coverage Δ
cmd/neofs-node/morph.go 0.00% <0.00%> (ø)
pkg/innerring/innerring.go 0.00% <0.00%> (ø)
pkg/morph/client/constructor.go 0.00% <0.00%> (ø)
cmd/neofs-node/config/morph/config.go 95.83% <85.71%> (ø)
pkg/innerring/config.go 97.70% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roman-khimov roman-khimov merged commit 8c56e89 into nspcc-dev:master May 24, 2023
@notimetoname notimetoname deleted the fix/morph-and-metrics-panics branch May 24, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants