cli: drop support for binary keys, use wallets #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6dd127 to
fc67a58
Compare
fc67a58 to
7537d25
Compare
Codecov Report
@@ Coverage Diff @@
## master #2357 +/- ##
=======================================
Coverage 29.93% 29.93%
=======================================
Files 398 398
Lines 29743 29742 -1
=======================================
+ Hits 8903 8904 +1
+ Misses 20122 20120 -2
Partials 718 718
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7537d25 to
79ce05c
Compare
notimetoname
approved these changes
May 24, 2023
aprasolova
reviewed
May 24, 2023
| @@ -35,6 +36,12 @@ Changelog for NeoFS Node | |||
| - `morph.switch_interval` IR and SN config value is not used anymore. | |||
| - `morph.rpc_endpoint` SN config value and `morph.endpoint.client` IR config value has been deprecated and will be | |||
| removed with the next minor release. Use `morph.endpoints` for both instead (NOTE: it does not have priorities now). | |||
| - If you're using binary keys with neofs-cli (`-w`), convert them to proper | |||
There was a problem hiding this comment.
Please, could you duplicate this manual to README or any place where it'd be easy to find?
There was a problem hiding this comment.
I think it's only relevant for this upgrade and careful admins read this documentation when they perform upgrade. And frankly I don't expect to see anyone still using these binaries keys, they're not even easy to create now (everyone just goes neo-go wallet create route).
cthulhu-rider
approved these changes
May 24, 2023
Wallets were introduced way back when in 0.27.5 and that's the way keys should be stored. We've had enough transition period for people to adjust to using them. Binary keys are dangerous and inconvenient (NEP-6 is common for all of the Neo tooling, everyone knows how to use it), therefore we shouldn't provide support for them. Related to #2136. Signed-off-by: Roman Khimov <roman@nspcc.ru>
79ce05c to
ff48ef7
Compare
This was referenced Jun 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallets were introduced way back when in 0.27.5 and that's the way keys should be stored. We've had enough transition period for people to adjust to using them. Binary keys are dangerous and inconvenient (NEP-6 is common for all of the Neo tooling, everyone knows how to use it), therefore we shouldn't provide support for them.
Related to #2136.