Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify help for --expire-at parameter for commands object lock/put and bearer create #2169

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Clarify help for --expire-at parameter for commands object lock/put and bearer create #2169

merged 1 commit into from
Dec 22, 2022

Conversation

acid-ant
Copy link
Contributor

Closes #2097 and #2099

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

@codecov
Copy link

codecov bot commented Dec 21, 2022 •
edited
Loading

Codecov Report

Merging #2169 (1d810c5) into master (cde6b89) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1d810c5 differs from pull request most recent head e935583. Consider uploading reports for the commit e935583 to get more accurate results

@@           Coverage Diff           @@
##           master    #2169   +/-   ##
=======================================
  Coverage   30.80%   30.81%           
=======================================
  Files         382      382           
  Lines       28161    28161           
=======================================
+ Hits         8676     8677    +1     
+ Misses      18755    18754    -1     
  Partials      730      730
Impacted Files Coverage Δ
pkg/local_object_storage/engine/get.go 82.14% <0.00%> (+1.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This was referenced Dec 21, 2022
Closed
Closed
carpawell
carpawell reviewed Dec 21, 2022
View reviewed changes
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you recheck all expire-at flag descriptions? It must mean the same for all the entities (objects, storage groups, locks, tokens, etc)

@carpawell carpawell mentioned this pull request Dec 21, 2022
Closed
@acid-ant
[nspcc-dev#2097] cli: Clarify help for --expire-at parameter for co…
e935583 
…mmands `object lock/put` and `bearer create`

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
@fyrchik fyrchik merged commit f4c3e40 into nspcc-dev:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyrchik fyrchik fyrchik approved these changes

@carpawell carpawell carpawell approved these changes

@alexvanin alexvanin Awaiting requested review from alexvanin

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

@anatoly-bogatyrev anatoly-bogatyrev Awaiting requested review from anatoly-bogatyrev

@realloc realloc Awaiting requested review from realloc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Locked object can be deleted on one extra epoch away from lock expiration
3 participants
@acid-ant @fyrchik @carpawell