Feat/Expire SGs based on its attributes #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
- Coverage 35.71% 35.66% -0.05%
==========================================
Files 308 308
Lines 18249 18274 +25
==========================================
Hits 6517 6517
- Misses 11182 11207 +25
Partials 550 550
Continue to review full report at Codecov.
|
fyrchik
suggested changes
Jun 29, 2022
Comment on lines
+38
to
+39
| // EpochSource is an interface that provides actual | ||
| // epoch information. | ||
| EpochSource interface { | ||
| // EpochCounter must return current epoch number. | ||
| EpochCounter() uint64 | ||
| } |
There was a problem hiding this comment.
it has different method names, also we have that approach (a separate interface in the processor) in netmap processor and some other processors
do you want me to add another wrapper in the innerring constructor or to unify all the netmap state interfaces and put it to the pkg/core/netmap.State?
Also, move common flag constants in `root` file of the `storagegroup` package. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Do not use `Marshal()` with object's payload. Use `ReadFromObject` func from SDK instead. That allows checking both attributes and SG body's expiration epoch. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
That allows using `ClientCache` for storage group searching before task context is initialized. Also, that makes it more general purpose. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Also, add corresponding structure for that. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
fyrchik
approved these changes
Jul 4, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Also, move common flag constants in `root` file of the `storagegroup` package. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Do not use `Marshal()` with object's payload. Use `ReadFromObject` func from SDK instead. That allows checking both attributes and SG body's expiration epoch. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
That allows using `ClientCache` for storage group searching before task context is initialized. Also, that makes it more general purpose. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
`auditor` does not need to request SG: processor will fetch that info before audit context initialization. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Also, add corresponding structure for that. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1225.
Based on nspcc-dev/neofs-sdk-go#245. Merging must be synced with nspcc-dev/neofs-api#205. Also it is impossible to merge that PR until the master branch of the SDK is adopted in the node.