Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not vote for the same node on IR start #2365

Closed
roman-khimov opened this issue Jun 1, 2023 · 0 comments · Fixed by #2443
Closed

Do not vote for the same node on IR start #2365

roman-khimov opened this issue Jun 1, 2023 · 0 comments · Fixed by #2443
Assignees
@carpawell
Labels
enhancement Improving existing functionality neofs-ir Inner Ring node application issues
Milestone
v0.38.0

Comments

@roman-khimov
Copy link
Member

Expected Behavior

Voting should be done when it can change something.

Current Behavior

IR node will vote for whatever key is written into its config unconditionally.

Possible Solution

Check NEO state before voting, likely there is already a vote and likely it's for the same key.

Steps to Reproduce (for bugs)

Restart IR node.

Context

Related to #2363.
@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-ir Inner Ring node application issues labels Jun 1, 2023
@roman-khimov roman-khimov added this to the v0.38.0 milestone Jun 1, 2023
@roman-khimov roman-khimov mentioned this issue Jun 20, 2023
Open
carpawell added a commit to carpawell/neofs-node that referenced this issue Jul 17, 2023
@carpawell
ir: Do not vote for the same validators list twice
3f83f51 
Closes nspcc-dev#2365.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell mentioned this issue Jul 17, 2023
Merged
carpawell added a commit to carpawell/neofs-node that referenced this issue Jul 24, 2023
@carpawell
ir: Do not vote for the same validators list twice
e77a8d1 
Closes nspcc-dev#2365.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Jul 24, 2023
@carpawell
ir: Do not vote for the same validators list twice
d0fe1b5 
Closes nspcc-dev#2365.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Jul 25, 2023
@carpawell
ir: Do not vote for the same validators list twice
c51eca8 
Closes nspcc-dev#2365.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Jul 25, 2023
@carpawell
ir: Do not vote for the same validators list twice
303ab1d 
Closes nspcc-dev#2365.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Jul 25, 2023
@carpawell
ir: Do not vote for the same validators list twice
8467193 
Closes nspcc-dev#2365.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Jul 27, 2023
@carpawell
ir: Do not vote for the same validators list twice
1eb6273 
Closes nspcc-dev#2365.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
roman-khimov added a commit that referenced this issue Jul 27, 2023
@roman-khimov
fix/Do not vote for the same validators list twice (#2443)
12e8b08 
Closes #2365.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality neofs-ir Inner Ring node application issues
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging a pull request may close this issue.

fix/Do not vote for the same validators list twice carpawell/neofs-node
2 participants
@roman-khimov @carpawell