Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netmap: add a temporary usev2 flag #461

Merged
merged 1 commit into from
Jan 24, 2025
Merged

netmap: add a temporary usev2 flag #461

merged 1 commit into from
Jan 24, 2025

Conversation

roman-khimov
Copy link
Member

Use it for any new installations, but hold back old ones till they're migrated.

Use it for any new installations, but hold back old ones till they're migrated.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is ok

pls describe a motivation in the commit, why it's needed, how it's gonna be used and, if it is temporary, when will go

@carpawell
Copy link
Member

Agree, the purpose is not clear.

@roman-khimov
Copy link
Member Author

The purpose is nspcc-dev/neofs-node#3088. And also to have new map only for new installations.

@roman-khimov
Copy link
Member Author

It can technically work without zero pushed into the DB on update, but one for new installations is important enough to me, I don't want to have legacy being used for new installations.

@cthulhu-rider cthulhu-rider merged commit 2477b0e into master Jan 24, 2025
8 checks passed
@cthulhu-rider cthulhu-rider deleted the use-node-v2 branch January 24, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants