Minor repository enhancements #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f718018 to
f53ecf0
Compare
carpawell
reviewed
Nov 30, 2023
| @tar --transform "s|^./|neofs-contract-$(VERSION)/|" \ | ||
| -C contracts -czf neofs-contract-$(VERSION).tar.gz \ | ||
| $(shell cd contracts && find . -name '*.nef' -o -name 'config.json') | ||
| rm -rf ./bin $(foreach sc,$(all_sc),contracts/$(sc)/contract.nef contracts/$(sc)/config.json contracts/$(sc)/bindings_config.yml) |
There was a problem hiding this comment.
btw, why ./bin here? we do not have it anywhere
There was a problem hiding this comment.
We do.
I meant even if we have it somewhere under some var, we do not clean that var, we clean hardcoded ./bin
There was a problem hiding this comment.
Because it's a part of GOBIN and the way it's derived (and can be overriden) doesn't make me comfortable using GOBIN directly.
Signed-off-by: Roman Khimov <roman@nspcc.ru>
* reuse wrapper * drop useless rpcNeo Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's not required. Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's a bit hard to navigate here now. "common" stays as is to minimize import changes. Signed-off-by: Roman Khimov <roman@nspcc.ru>
It was useful way back when we had multiple alphabet contracts, now it does nothing. Signed-off-by: Roman Khimov <roman@nspcc.ru>
This requires renaming source files, but we can still have compatible output NEFs which is important for neofs-adm. Signed-off-by: Roman Khimov <roman@nspcc.ru>
f53ecf0 to
6af653f
Compare
carpawell
approved these changes
Nov 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc/build/cleanup.