Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable smart contracts coverage #429

Closed
AnnaShaleva opened this issue Aug 16, 2024 · 0 comments · Fixed by #439
Closed

Enable smart contracts coverage #429

AnnaShaleva opened this issue Aug 16, 2024 · 0 comments · Fixed by #439
Labels
feature Completely new functionality I4 No visible changes S1 Highly significant U3 Regular
Milestone
v0.21.0

Comments

@AnnaShaleva
Copy link
Member

nspcc-dev/neo-go#3462 is almost done, thus coverage is unlocked for NeoFS contracts. We need to:

  1. Add make target to collect contracts coverage. Be careful since this repo contains not only contracts, but also simple Go code.
  2. Add GithubAction job that will collect and report contracts coverage.
  3. Add a coverage badge to README.
  4. Profit! Space for contracts coverage improvement is created.
@AnnaShaleva AnnaShaleva added U3 Regular S2 Regular significance I4 No visible changes feature Completely new functionality labels Aug 16, 2024
@AnnaShaleva AnnaShaleva mentioned this issue Aug 16, 2024
Merged
@roman-khimov roman-khimov added S1 Highly significant and removed S2 Regular significance labels Aug 18, 2024
@roman-khimov roman-khimov added this to the v0.21.0 milestone Aug 18, 2024
AnnaShaleva added a commit that referenced this issue Oct 7, 2024
@AnnaShaleva
Makefile: add cover target
1a56df5 
Collect coverage for contracts, a part of #429.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Oct 7, 2024
@AnnaShaleva
.github: add Coverage workflow
905a5be 
A part of #429.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Oct 7, 2024
@AnnaShaleva
README: add missing badges
a0c932c 
Including Coverage badge, a part of #429.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva mentioned this issue Oct 7, 2024
Merged
AnnaShaleva added a commit that referenced this issue Oct 7, 2024
@AnnaShaleva
.github: add Coverage workflow
3a7fdb4 
A part of #429.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Oct 7, 2024
@AnnaShaleva
README: add missing badges
0c05b45 
Including Coverage badge, a part of #429.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov pushed a commit that referenced this issue Feb 18, 2025
@AnnaShaleva @roman-khimov
Makefile: add cover target
b2dab82 
Collect coverage for contracts, a part of #429.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov pushed a commit that referenced this issue Feb 18, 2025
@AnnaShaleva @roman-khimov
.github: add Coverage workflow
d8e593f 
A part of #429.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov pushed a commit that referenced this issue Feb 18, 2025
@AnnaShaleva @roman-khimov
README: add missing badges
45e6fed 
Including Coverage badge, a part of #429.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov added a commit that referenced this issue Feb 18, 2025
@roman-khimov
*: enable coverage (#439)
f81d9d0 
Closes #429.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Completely new functionality I4 No visible changes S1 Highly significant U3 Regular
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging a pull request may close this issue.

*: enable coverage nspcc-dev/neofs-contract
2 participants
@roman-khimov @AnnaShaleva