Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up NeoFS chain deployment from scratch with set_roles_in_genesis option #409

Closed
cthulhu-rider opened this issue Dec 20, 2023 · 0 comments · Fixed by #410
Closed

Speed up NeoFS chain deployment from scratch with set_roles_in_genesis option #409

cthulhu-rider opened this issue Dec 20, 2023 · 0 comments · Fixed by #410
Assignees
@carpawell
Labels
enhancement Improving existing functionality I3 Minimal impact performance More of something per second S3 Minimally significant U2 Seriously planned

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Dec 20, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

IR launched in auto-deployment mode always deploys NNS first when starting from scratch. This requires some time to wait blocks so so that the deployer (now it's always committee member Az) has enough GAS

when option
https://github.com/nspcc-dev/neofs-node/blob/5c66479ee4bbd727c74abab8e635eb74aea4cf9d/config/example/ir.yaml#L86-L88
is enabled, IR is able to fill committee accounts with GAS insta cuz Notary system is completely ready for work starting from the genesis block

Describe the solution you'd like

in auto-deployment procedure, 1st of all check the Notary service's readiness for consumption by the committee. If roles are unset, continue as always (deploy NNS and so on), otherwise, make GAS transfer stage 1st, and then perform all other stages with ready-to-go GAS. Taking into account how much GAS is required for the NNS deployment, this approach should speed up the whole procedure for deploying the network

Describe alternatives you've considered

leave anything untouched: everything works now but takes a bit more time (depending on
https://github.com/nspcc-dev/neofs-node/blob/5c66479ee4bbd727c74abab8e635eb74aea4cf9d/config/example/ir.yaml#L37-L38
to be more precise). Need to see how much we win with proposed solution
@cthulhu-rider cthulhu-rider added the performance More of something per second label Dec 20, 2023
@roman-khimov roman-khimov added U2 Seriously planned S3 Minimally significant I3 Minimal impact enhancement Improving existing functionality labels Dec 21, 2023
@carpawell carpawell self-assigned this Jun 21, 2024
@carpawell carpawell transferred this issue from nspcc-dev/neofs-node Jun 21, 2024
carpawell added a commit that referenced this issue Jun 21, 2024
@carpawell
deploy: transfer GAS in the first place if notaries are set
c1bbe5c 
It is possible to start blockchain with required roles already set. In this
case, there is no need to wait for NNS to be deployed for GAS transfers, since
notary service (requires Notary roles to be set correctly) is ready. It allows
all multi-signed operations to be applied at an earlier stage. Closes #409.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell mentioned this issue Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality I3 Minimal impact performance More of something per second S3 Minimally significant U2 Seriously planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deploy: transfer GAS in the first place if notaries are set nspcc-dev/neofs-contract
3 participants
@roman-khimov @carpawell @cthulhu-rider