-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement some of good practices for the contracts #307
Labels
enhancement
Improving existing functionality
I4
No visible changes
S2
Regular significance
U4
Nothing urgent
Milestone
Comments
AnnaShaleva
added a commit
that referenced
this issue
Jan 31, 2023
AnnaShaleva
added a commit
that referenced
this issue
Jan 31, 2023
Part 1 from #307. Signed-off-by: Anna Shaleva <anna@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this issue
Jan 31, 2023
Part 2 from #307. Signed-off-by: Anna Shaleva <anna@nspcc.ru>
Suggestions 1 and 2 are implemented in #317. Suggestion 3 is left to be implemented in a separate PR, as it requires careful review of the contract API's users in the node's code. |
AnnaShaleva
added a commit
that referenced
this issue
Feb 1, 2023
Part 2 from #307. Signed-off-by: Anna Shaleva <anna@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Jun 18, 2024
Part of #307, makes code a bit more efficient. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Jun 18, 2024
Part of #307. NeoFS node currently passes and parses byte arrays here which is a compatible behavior. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Jun 18, 2024
Part of #307, makes code a bit more efficient. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Jun 18, 2024
Part of #307. NeoFS node currently passes and parses byte arrays here which is a compatible behavior. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Merged
roman-khimov
added a commit
that referenced
this issue
Jun 20, 2024
Prefix-less storage is dangerous, can be easily mixed with something else for different calls. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Jun 21, 2024
Prefix-less storage is dangerous, can be easily mixed with something else for different calls. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improving existing functionality
I4
No visible changes
S2
Regular significance
U4
Nothing urgent
Some of our contracts contain issues that need to be refactored:
common.BytesEqual
usages with built-in(a Hash160) Equals(b interface{}) bool
where possible (seeneofs-contract/alphabet/alphabet_contract.go
Line 30 in dc89137
interop.Hash160Len
,interop.PublicKeyCompressedLen
, etc.). There are still several cases where numbers are use instead (seeneofs-contract/container/container_contract.go
Line 472 in dc89137
interop.Hash160
instead of[]byte
), seeneofs-contract/neofs/neofs_contract.go
Line 371 in dc89137
Ref. #304.
The text was updated successfully, but these errors were encountered: