-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification for eXtended Headers in MetaHeader #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about mentioning two well-known headers in corresponding RPC method docs?
@@ -42,6 +52,13 @@ service ObjectService { | |||
// object payload. All messages, except first one, SHOULD be payload chunks. | |||
// Chunk messages SHOULD be sent in direct order of fragmentation. | |||
// | |||
// Extended headers can change `Put` behaviour: | |||
// * __NEOFS__NETMAP_EPOCH \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is useful for Put
: can't imagine the scenario when somebody wants to store an object in the "past" and storage nodes accepts it.
Same for Delete
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functionality is required to address cases with some network segments losing full connectivity. Even if it's not used now by our implementation, the protocol itself must support operation in an Epoch specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we can parameterize this value in binary protocol, but I still can't imagine the UX in setting the particular values. Regardless of the implementation, how are storage nodes that are no longer present in the container motivated to serve these kinds of requests?
Minor clarification to show how XHeaders should be used. Signed-off-by: Stanislav Bogatyrev <stanislav@nspcc.ru>
Minor clarification to show how XHeaders should be used.