Pass sidechain magic in requests #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Jan 10, 2022
- closes Sidechain Magic number should be used in NeoFS requests #82
realloc
reviewed
Jan 10, 2022
added 2 commits
January 10, 2022 16:04
To prevent theoretical cross-network replay attack, we need to have network magic in NeoFS requests. Add `magic_number` numeric field to `session.RequestMetaHeader` message. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
After the recent update of NeoFS V2 protocol all requests must carry correct network magic. Add `WRONG_MAGIC_NUMBER` code to `CommonFail` section. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
2376cc1 to
f940131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.