netmap: add subnet id to placement policy #182
Conversation
refs/types.proto
Outdated
| // | ||
| // String representation is base-10 integer value. | ||
| // | ||
| // JSON representation is a JSON number. |
There was a problem hiding this comment.
Suffice it to say that it corresponds to the standard Protocol Buffers JSON format. If you want to explicitly describe the format of this message, then this is an object with a numeric field value.
Btw we do not guarantee the JSON compatibility, so refine the format is optional.
refs/types.proto
Outdated
| @@ -77,6 +77,18 @@ message OwnerID { | |||
| bytes value = 1 [json_name = "value"]; | |||
| } | |||
|
|
|||
| // NeoFS subnetwork identifier. | |||
| // | |||
| // `SubnetID` is a 4-byte long. | |||
There was a problem hiding this comment.
Suffice it to say that it corresponds to the standard NeoFS binary format which is Protocol Buffers with direct orders of fields (I'm not sure it is actually 4-byte long because of prefixes).
There was a problem hiding this comment.
Doc shouldn't really describe the format (we are talking about .proto file after all), but having explicit id size is something I would like to know from the doc. Moved this to the field comment.
| // JSON representation is a JSON number. | ||
| message SubnetID { | ||
| // Integer subnetwork identifier. | ||
| fixed32 value = 1 [json_name = "value"]; |
There was a problem hiding this comment.
Let's clearly indicate that zero identifies the zero subnet.
There was a problem hiding this comment.
This is more about the PlacementPolicy interpretatiion than the id itself.
There was a problem hiding this comment.
why have you chosen
fixed32?
fixed32 was mentioned for in-place ID checks in smart contract. With uint32, field will be encoded as varint, which is much harder to decode.
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Close #179 .