Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting CID object search V2 #318

Closed
cthulhu-rider opened this issue Jan 23, 2025 · 2 comments
Closed

Stop supporting CID object search V2 #318

cthulhu-rider opened this issue Jan 23, 2025 · 2 comments
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U2 Seriously planned
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Jan 23, 2025

Is your feature request related to a problem? Please describe.

search queries may contain

// * $Object:containerID \
// container_id
filter. These filters make almost no sense, since CID is a request field itself, i.e. selector. So, either:

  • filter is no-op (e.g. REQ_FIELD EQ REQ_FIELD)
  • the result is a priori empty (e.g. REQ_FIELD NE REQ_FIELD), and this does not require server processing

Describe the solution you'd like

deprecate it. Then, after one release, stop the support

Additional context

SearchV2 server implementation

@cthulhu-rider cthulhu-rider added discussion Open discussion of some problem enhancement Improving existing functionality labels Jan 23, 2025
@roman-khimov
Copy link
Member

For searchv2 we can remove it immediately, it's not there yet (not even in the released API version). Keep it v1-only and deprecated.

@roman-khimov roman-khimov added U2 Seriously planned S3 Minimally significant I3 Minimal impact and removed discussion Open discussion of some problem labels Jan 23, 2025
@roman-khimov roman-khimov added this to the v2.17.0 milestone Jan 23, 2025
@cthulhu-rider
Copy link
Contributor Author

i also propose to prohibit using CID in

// List of attribute names (including special ones as defined by
// SearchFilter key) to include into the reply. Limited to 4, these
// attributes also affect result ordering (result is ordered by attributes
// and then by OID).
repeated string attributes = 6;

cthulhu-rider added a commit that referenced this issue Feb 18, 2025
Container ID is a request field while the object ID a resulting item's
one.

Closes #318. Closes #319.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants