Skip to content
This repository has been archived by the owner on Dec 27, 2024. It is now read-only.

v2/acl: add Service filter type #338

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Sep 14, 2021

Depends on nspcc-dev/neofs-api#173

Signed-off-by: Evgenii Stratonikov evgeniy@nspcc.ru

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #338 (7c6f198) into master (6d0b313) will decrease coverage by 0.00%.
The diff coverage is 63.63%.

❗ Current head 7c6f198 differs from pull request most recent head f65fc5c. Consider uploading reports for the commit f65fc5c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   63.05%   63.05%   -0.01%     
==========================================
  Files         119      119              
  Lines       13844    13853       +9     
==========================================
+ Hits         8730     8735       +5     
- Misses       4122     4126       +4     
  Partials      992      992              
Impacted Files Coverage Δ
v2/acl/convert.go 66.76% <0.00%> (-0.81%) ⬇️
v2/acl/types.go 40.81% <ø> (ø)
pkg/acl/eacl/enums.go 100.00% <100.00%> (ø)
pkg/owner/wallet.go 57.14% <100.00%> (+2.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0b313...f65fc5c. Read the comment docs.

Copy link
Contributor

@alexvanin alexvanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support it in pkg/acl/eacl/enums.go as well.

@@ -1,7 +1,7 @@
// Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
// protoc-gen-go v1.23.0
// protoc v3.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it's better to recompile all protobuf files then, or use protoc v3.14.

/cc @cthulhu-rider @carpawell

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd rather keep it v3.14.0 and recompile all files in a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem with leaving this as it is? protoc-gen-go is specified in our makefile, protoc is not, so I used the system default.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
@alexvanin alexvanin merged commit 520a065 into nspcc-dev:master Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants