Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: remove crypto-related opcodes #917

Merged
merged 1 commit into from
Apr 29, 2020
Merged

vm: remove crypto-related opcodes #917

merged 1 commit into from
Apr 29, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Apr 29, 2020

All cryptography has moved to interops in NEO3.
There is no SHA256 interop RN, but it is to appear later.

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #917 into master will increase coverage by 0.70%.
The diff coverage is 64.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
+ Coverage   63.45%   64.15%   +0.70%     
==========================================
  Files         196      194       -2     
  Lines       16534    16258     -276     
==========================================
- Hits        10492    10431      -61     
+ Misses       5502     5296     -206     
+ Partials      540      531       -9     
Impacted Files Coverage Δ
pkg/compiler/analysis.go 95.80% <ø> (ø)
pkg/config/protocol_config.go 70.00% <ø> (+6.36%) ⬆️
pkg/core/gas_price.go 100.00% <ø> (+8.00%) ⬆️
pkg/core/interop_neo.go 59.58% <ø> (-0.58%) ⬇️
pkg/core/interops.go 100.00% <ø> (ø)
pkg/core/state/account.go 95.52% <ø> (-0.43%) ⬇️
pkg/core/storage/store.go 42.30% <ø> (ø)
pkg/core/transaction/transaction.go 82.25% <ø> (+1.09%) ⬆️
pkg/core/transaction/type.go 72.97% <ø> (-10.71%) ⬇️
pkg/interop/crypto/crypto.go 0.00% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1aa96d...519b31a. Read the comment docs.

@roman-khimov
Copy link
Member

Closes #777?

All cryptography has moved to interops in NEO3.
There is no SHA256 interop RN, but it is to appear later.
Closes #777.
@roman-khimov roman-khimov merged commit fda943b into master Apr 29, 2020
@roman-khimov roman-khimov deleted the feature/crypto branch April 29, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Go smart contract compiler vm VM tasks/bugs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants