core: optimize HasBlock check for recent blocks #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When block is being spread through the network we can get a lot of invs with the same hash. Some more stale nodes may also announce previous or some earlier block. We can avoid full DB lookup for them and minimize inv handling time (timeouts in inv handler had happened in #2744). It doesn't affect tests, just makes node a little less likely to spend some considerable amount of time in the inv handler.
Codecov Report
@@ Coverage Diff @@
## master #2759 +/- ##
==========================================
+ Coverage 85.21% 85.24% +0.02%
==========================================
Files 324 324
Lines 40150 40159 +9
==========================================
+ Hits 34215 34234 +19
+ Misses 4562 4555 -7
+ Partials 1373 1370 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnnaShaleva
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When block is being spread through the network we can get a lot of invs with the same hash. Some more stale nodes may also announce previous or some earlier block. We can avoid full DB lookup for them and minimize inv handling time (timeouts in inv handler had happened in #2744).
It doesn't affect tests, just makes node a little less likely to spend some considerable amount of time in the inv handler.