Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: check inv against currently processed transactions #2758

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

roman-khimov
Copy link
Member

Sometimes we already have it, but it's not yet processed, so we can save on getdata request. It only affects very high-speed networks like 4-1 scenario and it doesn't affect it a lot, but still we can do it.

Tests on top of #2757:
cpu_four_(30_wrk,_64K_pool,_200ms)
cpu_four_(30_wrk,_64K_pool)
cpu_seven_(30_wrk,_64K_pool,_200ms)
cpu_seven_(30_wrk,_64K_pool)
mem_four_(30_wrk,_64K_pool,_200ms)
mem_four_(30_wrk,_64K_pool)
mem_seven_(30_wrk,_64K_pool,_200ms)
mem_seven_(30_wrk,_64K_pool)
ms_per_block_four_(30_wrk,_64K_pool,_200ms)
ms_per_block_four_(30_wrk,_64K_pool)
ms_per_block_seven_(30_wrk,_64K_pool,_200ms)
ms_per_block_seven_(30_wrk,_64K_pool)
tpb_four_(30_wrk,_64K_pool,_200ms)
tpb_four_(30_wrk,_64K_pool)
tpb_seven_(30_wrk,_64K_pool,_200ms)
tpb_seven_(30_wrk,_64K_pool)
tps_four_(30_wrk,_64K_pool,_200ms)
tps_four_(30_wrk,_64K_pool)
tps_seven_(30_wrk,_64K_pool,_200ms)
tps_seven_(30_wrk,_64K_pool)

Sometimes we already have it, but it's not yet processed, so we can save on
getdata request. It only affects very high-speed networks like 4-1 scenario
and it doesn't affect it a lot, but still we can do it.
@roman-khimov roman-khimov added network P2P layer performance More of something per second labels Oct 21, 2022
@roman-khimov roman-khimov added this to the v0.99.5 milestone Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #2758 (e260551) into master (bf4636f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2758      +/-   ##
==========================================
+ Coverage   85.21%   85.23%   +0.02%     
==========================================
  Files         324      324              
  Lines       40150    40154       +4     
==========================================
+ Hits        34215    34227      +12     
+ Misses       4562     4558       -4     
+ Partials     1373     1369       -4     
Impacted Files Coverage Δ
pkg/network/server.go 73.15% <100.00%> (+0.09%) ⬆️
pkg/consensus/consensus.go 73.31% <0.00%> (-0.44%) ⬇️
pkg/core/transaction/transaction.go 86.66% <0.00%> (+1.48%) ⬆️
pkg/network/message.go 94.77% <0.00%> (+2.23%) ⬆️
pkg/network/compress.go 76.00% <0.00%> (+12.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roman-khimov roman-khimov merged commit f42b8e7 into master Oct 24, 2022
@roman-khimov roman-khimov deleted the check-inflight-tx-invs branch October 24, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network P2P layer performance More of something per second
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants